Add public_descriptor to wallet implementation#786
Merged
reez merged 1 commit intobitcoindevkit:masterfrom Jun 19, 2025
Merged
Conversation
Member
|
lol I can't believe we didn't have this API exposed before! Thanks Itoro. |
Collaborator
Author
|
Thanks for the review! @reez |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
I have been working with wallet and our descriptor type for my work on Psbt and multisig. I noticed that we cannot get the descriptor used to create the wallet directly from the
Wallettype. Hence exposing public_descriptor will allow us get this directly. A good use case is if you want to create a watch only wallet you could just callpublic_descriptor.At the moment I am returning the descriptor as a string instead of a ExtendedDescriptor. The downside to this is we loose all the functionality
ExtendedDescriptorprovides. We do not have a ExtendedDescriptor type which is just an alias forDescriptor<DescriptorPublicKey>.We could create and implement the type if necessary instead of using a string.
Checklists
All Submissions:
cargo fmtandcargo clippybefore committingNew Features: